Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

All work

Go to all work items
Select view

Select search mode

 
38 of 38

Look to reducing the use of "v2Parser" in the Data Connector parsers

Won't Fix

Description

As we developed V3 it was not obvious whether attribute definition specifications would end up using custom syntax or native spring.

To that end the parsers separate “V2 parsing” into a separate class (which mostly serves as a container for the Configuration DOM element.

So we see code like this

@Nullable public BeanDefinition createCache(@Nonnull final ParserContext parserContext) { final CacheConfigParser parser = new CacheConfigParser(configElement); return parser.createCache(); }

This case is about stripping away this stuff and seeing what it left.

Environment

None

Details

Assignee

Reporter

Components

Affects versions

Created January 20, 2025 at 3:40 PM
Updated March 24, 2025 at 11:17 AM
Resolved March 24, 2025 at 11:17 AM

Activity

Rod WiddowsonMarch 24, 2025 at 11:17 AM

This code works. It's slightly weird but there are too many ways in which a refactoring could make things worse.

We might not go here if we were starting from scratch but what we have works

Rod WiddowsonMarch 24, 2025 at 10:36 AM

I’ll take a poke. This feels a bit scary for 5.2 (in my mind it was part of the 6.0 cleanup, but it is non-api). Maybe I’ll do this on a branch

Flag notifications