Allow various classes to skip servlet request check at init time
Basics
Logistics
Basics
Logistics
Description
The servlet-based message decoders do an init-time check that a servlet request is present. The SP has ordering issues making that impossible to satisfy so either I have to redo some code, or possibly just add a flag to skip that check, which seems like less work.
The crux is that the decoders are passed into the DecodeMessage profile action at constructor arg time and not created via a factory step later, but I think it’s more work to change that.
Environment
None
Activity
Scott Cantor April 2, 2025 at 3:35 PM
Enabled this for the new parameter validator action created for the 5.1.4 patch as the SP needs that code as well.
Scott Cantor October 2, 2024 at 6:20 PM
Initial set adjusted, leaving open if anything else comes up.
Scott Cantor October 2, 2024 at 5:59 PM
Also need to address ValidateAssertions profile action.
Scott Cantor October 2, 2024 at 2:17 PM
Edited
A couple of message handlers are also implicated with this unfortunately, can’t be helped.
The fix isn’t hard, just invasive and renders the annotations somewhat inaccurate, but can’t really be helped.
I did note that the MessageHandlers all lack a base class that handles the servlet request set up, so that looks like a refactoring opportunity to save me time fixing this ten times.
The servlet-based message decoders do an init-time check that a servlet request is present. The SP has ordering issues making that impossible to satisfy so either I have to redo some code, or possibly just add a flag to skip that check, which seems like less work.
The crux is that the decoders are passed into the DecodeMessage profile action at constructor arg time and not created via a factory step later, but I think it’s more work to change that.