MD generator creates invalid metadata - lang attributes missing for DisplayName and Description

Basics

Logistics

Basics

Logistics

Description

Hi,

I’ve tried loading the metadata generated by IdP installer (and served at /idp/shibboleth) into a Shibboleth SP (from a local file copy, in a test-bed setup).

When loading the metadata with:

SP rejected it with:

and with validate="false" or without validate:

I resolved it by adding xml:lang="en" to DisplayName and Description .

The MDUI extension in the metadata is:

but both DisplayName and Description are a localizedNameType and need a lang.

Given Logo is already rendered with xml:lang="en" , an easy fix would be to add the same also to DisplayName and Description .

Cheers,
Vlad

Environment

None

Linked work items

duplicates

OSJ-403

Metadata generation omits xml:lang tag in some spots

Activity

Scott Cantor May 16, 2024 at 12:27 PM

The plugin relies on a combination of code and templates, and the bug was in the templates. Those can be overridden by copying modified ones into views/templates/metadata/

The plugin doesn’t contain them, OpenSAML does, so it takes an IdP patch to fix it for either the installer (which doesn’t get to override the templates) or for the plugin without doing so.

I don’t really know that anybody is using the plugin, it was just a note for posterity.

Vlad Mencl May 15, 2024 at 9:30 PM

Thanks Scott!

Do I read the message correctly that it’s now fixed for metadata generated by the plugin …. but not for metadata generated by the IdP installer? Or did I misunderstand the message?

Scott Cantor May 15, 2024 at 3:55 PM

This was fixable with the templates only so it can be worked around in an actual instance of the plugin but the installer wouldn’t provide the chance to do so.