I would propose a small optimization regarding the logger handling for class org.opensaml.core.config.ConfigurationService:
Because of an bad behaving logger implementation behind SLF4j LoggerFactory.getLogger() we had a massive performance issue with getConfigurationProperties()/getLogger().
The bad behaving logger implementation was forced to rebuild the logger instance time and time again, with high CPU & memory impact.
To mitigate this problem we patched class org.opensaml.core.config.ConfigurationService the following way:
@@ -72,0 +73,4 @@ public class ConfigurationService {
Replaced all instances in java-opensaml with the standard idiom:
Looked, but didn’t find anything with this pattern in java-support, spring-extensions or java-identity-provider.
Brent PutmanMarch 23, 2021 at 6:06 PM
IIRC there use to be some recommendations from slf4j or logback that implied we shouldn't use static Logger instances in support classes that are primarily static methods. That's why in some of those you will see a method that produces an instance like that.
However, I think the recommendation has changed and they now say using static Logger is OK. So a simpler fix here is to just switch to a simple private static Logger.
We have several historical helper/support classes that do the method approach, so we should fix them all.
Hello,
I would propose a small optimization regarding the logger handling for class org.opensaml.core.config.ConfigurationService:
Because of an bad behaving logger implementation behind SLF4j LoggerFactory.getLogger() we had a massive performance issue with getConfigurationProperties()/getLogger().
The bad behaving logger implementation was forced to rebuild the logger instance time and time again, with high CPU & memory impact.
To mitigate this problem we patched class org.opensaml.core.config.ConfigurationService the following way:
@@ -72,0 +73,4 @@ public class ConfigurationService {
+ private static ThreadLocal<Logger> loggers = ThreadLocal.withInitial(() -> {
+ return LoggerFactory.getLogger(ConfigurationService.class);
+ });
+
@@ -228 +231 @@ public class ConfigurationService {
- return LoggerFactory.getLogger(ConfigurationService.class);
+ return loggers.get();
This generates a logger instance only if necessary, helping a lot with bad behaving implementations behind SLF4j.
Our currently used OpenSAML Core Version is 3.3.1. OpenSAML is used not directly but called from third party libraries such as Apache CXF