ZIP streams and inflater/deflaters need to be closed

Description

While researching some memory leak concerns, I noticed the streams used in the Redirect encoder/decoder aren't being closed formally, and the non-default stream constructors don't properly call the end() method on the Inflater/Deflater objects used.

Supposedly this causes RSS growth, but the GC should be calling finalize, which calls these methods, so this seems unlikely to matter all that much under ordinary use. Still should be cleaned up.

Environment

None

Activity

Scott Cantor 
September 23, 2019 at 11:28 PM

Scheduled for 4.0 for now, if this turns out to be more significant than we would expect, we can reschedule back to a patch.

Duplicate

Details

Assignee

Reporter

Components

Created September 23, 2019 at 11:27 PM
Updated September 24, 2019 at 12:32 AM
Resolved September 23, 2019 at 11:41 PM