Change default for noChildrenAProcessingError in EntitiesDescriptorAssemblerStage

Description

At present, the default behaviour of EntitiesDescriptorAssemblerStage if presented with an empty collection of items is to shrug and move on, ignoring the condition except for a log.debug.

There is a property, noChildrenAProcessingError, to change the behaviour to throw a StageProcessingError in this case. This should be the default.

Environment

None

Activity

Ian Young 
April 27, 2023 at 11:13 AM

Done, commit 963f441a33591838f46adab6be12403cbe2a370e.

Ian Young 
April 27, 2023 at 10:52 AM

Note that the “shrug and move on” behaviour results in a (still) empty item collection, which seems useless as any reasonable use case will want to make use of the resulting (albeit schema-invalid) aggregate. However, that’s not easy to change because there’s no DOM implementation available which could be used for the createDocument call, and no parser or (text) document to parse to acquire one incidentally.

So, throwing in the case of an empty input collection is definitely the right default.

Done

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created August 26, 2020 at 9:29 AM
Updated May 16, 2024 at 12:37 PM
Resolved April 27, 2023 at 11:19 AM