ItemIdTransformStage#setIdTransformers is additive, should be a setter

Description

I have no idea whether this is a bug or note but the method 

Is additive, not replacing.

Contrast the use of the same helper method in ItemMetadataAddingStage

Environment

None

Activity

Ian YoungMarch 13, 2020 at 2:01 PM

Added regression test, commit f9276e3335cd303c4b593d5469633dbeed8ab818.

Ian YoungMarch 13, 2020 at 1:51 PM

Fixed via and MDA-222, as anticipated.

Ian YoungNovember 2, 2019 at 3:08 PM

This is a bug in the implementation, plain and simple. I have no idea why it was implemented this way; the whole business of using LazyList and adding to it seems like classic premature optimisation but the bottom line is that this is clearly just a property setter for a collection of transformer functors. But there's no way to remove an element from the collection, so it should not be additive.

As such, this will get fixed en passant by the and changes, but I will record it separately anyway.

Thanks for noticing.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created November 1, 2019 at 1:40 PM
Updated May 16, 2024 at 12:37 PM
Resolved March 13, 2020 at 2:05 PM