Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

move SAML-specific methods down from AbstractDOMTraversalStage

Description

AbstractDOMTraversalStage includes a couple of helper methods which are SAML-specific: ancestorEntity and addError.

It would be fine to introduce an abstract subclass (e.g., AbstractSAMLTraversalStage to house these, but a more general approach involving a new abstract errorPrefix method might be better.

At present, ancestorEntity is only used by addError and that is only used in CRDetectionStage, so an even simpler solution would be to make both methods private and move them down there for now.

Environment

None

Activity

Show:

Ian Young September 7, 2017 at 1:36 PM

The addError element is also used in the ukf-mda project's SAMLStringElementCheckingStage, which suggests that an intermediate set of SAML-specific classes might make sense.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created September 7, 2017 at 11:01 AM
Updated May 16, 2024 at 12:37 PM
Resolved January 30, 2018 at 5:01 PM

Flag notifications