HTTPResource#createRelative returns a non initialized Object

Description

Find while reviewing the code in preparation for https://shibboleth.atlassian.net/browse/IDP-1599#icft=IDP-1599 and https://shibboleth.atlassian.net/browse/IDP-1595#icft=IDP-1595

net.shibboleth.ext.spring.resource.HTTPResource is an Initializable compoent (which it really doesn't need to be).

The only place where initializaibility is looked at is in #setHttpClientContextHandler() which is just as well because createRelative() and createRelativeResource() return uninitialized objects.

In V4.* we should add an expklicit initialize (for hygiene) and in V5 we should remove the Initializability.

This case covers the first.   I'll enter another case for the latter

Environment

None

Activity

Rod Widdowson May 8, 2020 at 3:39 PM

Done

Rod Widdowson May 8, 2020 at 3:04 PM

Fixed.  No resolving yet pending paperwork

Fixed

Details

Assignee

Reporter

Original estimate

Fix versions

Created May 8, 2020 at 2:35 PM
Updated March 22, 2021 at 9:50 PM
Resolved May 8, 2020 at 3:39 PM