deprecated Spring API suggests issue in our API

Description

SchemaTypeAwareBeanDefinitionParserDelegate extends a Spring class, and calls a constructor there which is now deprecated:

public SchemaTypeAwareBeanDefinitionParserDelegate( XmlReaderContext readerContext, Environment environment) { super(readerContext, environment); }

The deprecated super ignores the environment argument; there is now a 1-argument constructor replacing it.

We could and probably should compress that down so that SchemaTypeAwareBeanDefinitionParserDelegate's constructor does not have an environment parameter either, and calls the single-argument super.

However, I have some concern that the passed-in environment may have been relevant to what was going on in some way, and that we therefore need to look at the call sites to make sure that nothing has gone sideways.

Assigning to Rod after talking this one over with him.

Environment

None

Activity

Rod Widdowson 
December 11, 2014 at 1:40 PM

Looks pretty simple - just drop the ignore parameter to the constructor.

Fixed

Details

Assignee

Reporter

Fix versions

Affects versions

Created December 9, 2014 at 5:48 PM
Updated December 11, 2014 at 5:18 PM
Resolved December 11, 2014 at 4:48 PM