SubjectTypeImplBuilder typo causes invalid documents to be built

Description

(I cannot find the package org.opensaml.xacml in any of the public repositories so I chose opensaml2... apologies if this is reported against the wrong project)

There's an issue in opensaml 2.4.1 (which is also present in 2.3.1) when building a policy document, xacml:Subjects has a child called xacml:Action instead of xacml:Subject (which is corrupting our generated policies)

I have tracked this issue down to a typo in org.opensaml.xacml.policy.impl.SubjectTypeImplBuilder.

buildObject reads:

/** {@inheritDoc} */
public SubjectType buildObject() {
return buildObject(ActionType.DEFAULT_ELEMENT_NAME);
}

Whereas it should be:

/** {@inheritDoc} */
public SubjectType buildObject() {
return buildObject(SubjectType.DEFAULT_ELEMENT_NAME);
}

Environment

None

Activity

ChadC March 14, 2011 at 7:38 AM
Edited

Fixed in rev 1510

Peter Wright March 1, 2011 at 6:28 AM

Attaching version of SubjectTypeImplBuilder.java with the typo fixed

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created March 1, 2011 at 6:27 AM
Updated June 22, 2021 at 7:48 PM
Resolved March 14, 2011 at 7:38 AM