Review ProfileConfiguration interfaces and concrete classes
Description
Environment
Attachments
Activity
Philip SmartMay 5, 2023 at 8:12 AM
Merged and ready for 2.2.0
Philip SmartApril 19, 2023 at 1:34 PM
Having reviewed with Henri, I’ve moved three of the RP-specific client auth methods into a separate interface as the OP would never use them. I also inherited the PKCE methods into the RP interface. OP compiles and tests OK, and so does the RP (although RP can change, so less relevant). I think it is now ready to merge.
Philip SmartApril 18, 2023 at 3:12 PM
I’ve printed all the interface methods the various concrete classes expose (attached PDF). I will go through them with ASAP. If they look OK, I will merge the branch into main.
Philip SmartApril 17, 2023 at 4:39 PM
Renamed and moved OIDCTokenEncryptionProfileConfiguration and rebased the branch (so had to force push).
Philip SmartApril 17, 2023 at 4:03 PM
Yes, some of the names are to maintain current OP compatibility and I agree they should be changed over in 3.0.0.
OIDCTokenEncryptionProfileConfiguration should indeed be OAuth2 and moved over. I will do that now.
I will review the concrete profiles this week.
Review the profile configuration and add OP and or RP specific interfaces for configuration options specific to one or the other. Various places can then use the appropriate interface rather than the concrete classes.