logout.vm Does Not Correctly Render $request Variable

Fixed in r8190.

I plan to perform search and replace in all flow definition files to convert on-entry to on-render in all view-states. There may be only one in logout.vm, but it's clearly "the right thing" in general.

Kind of a left hand, right hand thing, where both hands are mine, but I used on-render in the password login form view, so I probably discovered some variant of this problem and then screwed up other views at some point and used the wrong element.

Point being, clearly on-render is fine since it's used in the heaviest used view now.

I think if we're looking for "best practice", it's clearly just to get it from flowRequestContext.

From a compatibility standpoint, we sort of made these variables a public API for the views, so if on-render works, we probably should populate it, but best avoided in what what we ship.

And we'll need to review all the other data we're making available. Our contexts should be safe since reloading views doesn't mutate it.

I suggest we review all flow definition files where we use on-entry and replace with on-render, since that's clearly what we want.