Spelling error in schacDateOfBirth attribute displayName
Description
Environment
Activity
It’s patched.
https://git.shibboleth.net/view/?p=java-identity-provider.git;a=blob;f=idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/attributes/schac.xml#l184 Line 184
I noticed one last minor error that has been introduced after translation:
Line 184 <prop key="displayName.en">Persönlicher Titel</prop>
should be
<prop key="displayName.de">Persönlicher Titel</prop>
that might cause german text to be displayed in english configuration.
Thank you. They’re applied in the java-idp-translations project, I will wait to apply them back to the IdP until next Monday when I sync everything up for the release.
Looking much better! Thanks for all the work!
Some minor suggestions/additions to the changes you made although not so relevant for us as the description is not displayed on our consent page:
<prop key="description.en">The country of residence for the subject</prop>
Suggestion: <prop key="description.en">The country of residence of the subject</prop>
<prop key="description.en">Personal position of the subject within theie institution</prop>
Suggestion: <prop key="description.en">Personal position of the subject within the institution</prop>
<prop key="description.en">Unique code for the subject it is associated with</prop>
Suggestion: <prop key="description.en">Personal unique code of the subject</prop>
<prop key="description.en">Unique Legal Identifier of a person</prop>
Suggestion: <prop key="description.en">Personal unique identifier of the subject</prop>
I cleaned up a number of descriptions as well. Using "person" or "user" is generally a bad way of going, so I changed them to use "subject".
https://git.shibboleth.net/view/?p=java-identity-provider.git;a=blob;f=idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/attributes/schac.xml#l66 Line 66
<prop key="displayName.en">Date or Birth</prop>
should be<prop key="displayName.en">Date of Birth</prop>