Migrate all unmanaged config files into core module
Description
Environment
causes
Confluence content
Activity
Rod WiddowsonMay 25, 2023 at 1:28 PM
Confirmed fixed. Thanks
I didn’t even know we had a replace option !
Rod WiddowsonMay 25, 2023 at 1:24 PM
I’d say that is absolutely the issue. I’ll pull the latest, rebase and try again.
Scott CantorMay 25, 2023 at 12:48 PMEdited
I’m not following the issue yet. Can you outline what I should do to reproduce it? All I do in bin/ is what I normally do, but I might need to mark these files as replaceable so they just always get replaced, I neglected to do that.
ETA: This is done, bin/ files are now all replaced. Is that the issue or is it something deeper?
Rod WiddowsonMay 25, 2023 at 11:02 AM
Something odd going on here.
I just upgraded a pre-this-change idp installation (on Debian) to the latest (with all the module changes). This means we are getting the V4->V5 behavior.
After the upgrade I see:
rdw@DELL10:~/idp/bin$ ls *5*
build.sh.idpnew-500-SNAPSHOT runclass.sh.idpnew-500-SNAPSHOT
rdw@DELL10:~/idp/bin$ diff build.sh build.sh.idpnew-500-SNAPSHOT
7c7,8
< $LOCATION/ant.sh "$@" build-war
---
> $LOCATION/runclass.sh net.shibboleth.idp.installer.impl.IdPBuildWar --ansi --home "$LOCATION/.." "$@"
>
rdw@DELL10:~/idp/bin$ diff runclass.sh runclass.sh.idpnew-500-SNAPSHOT
45c45
< LOCALCLASSPATH="$LOCATION/lib/*":$LOCALCLASSPATH
---
> LOCALCLASSPATH="$LOCATION/../dist/binlib/*":$LOCALCLASSPATH
rdw@DELL10:~/idp/bin$It looks like when it [re-]enabled the cli module it preserved the old version, which it should do. But not in this particular situation.
I’m guessing that this will be true going onwards: any changes to bin will not be reflected after an upgrade. We kinda don’t want this to happen. Do we?
I for one, don’t have a clue what to do about this.
Scott CantorMay 16, 2023 at 5:29 PM
I think this is done. idp-conf is deleted and the installer at least nominally seems to function and the files look ok. Upgrades still need to be tested, but those should be installer-related problems at this stage.
For completeness, it is useful that an upgrade process can generate *.idpnew file if the corresponding configuration file was customized and cannot be replaced.
Currently, configuration files in any module seem to generate *.idpnew files when they were customized.