Plugin installer ignores custom HttpClient (e.g. HTTP Proxy)
Basics
Technical
Logistics
Basics
Technical
Logistics
Description
Environment
None
Attachments
1
Activity
Show:
Rod Widdowson July 21, 2021 at 12:53 PM
I made the proposed fix (and tested it with the non functional bean you kindly provided).
the fix is in the branches for both 4.1.3 and 4.2. Feel free to pull and test if you want.
I
Rod Widdowson July 21, 2021 at 12:47 PM
I have made the change and tested it and it should be in the next release.
Meanwhile I would guess (I have not tested it) that --nocheck might allow you to proceed (because that is what that http client is used more)
When calling the plugin installer with a custom HttpClient like this:
/opt/shibboleth-idp/bin/plugin.sh --verbose -hc myHttpClient -i oidc-common-dist-1.1.0.tar.gz beanfile.xml
Then a custom HttpClient bean is created, but never handed over from net.shibboleth.idp.installer.plugin.impl.PluginInstaller to net.shibboleth.idp.installer.plugin.impl.PluginState instance.
A fix would be to add the following command in PluginInstaller.java:
state.setHttpClient(httpClient);before the following command is called:
state.initialize();