Enhance StaticPKIXFactoryBean to support PKIXTrustEvaluator and X509CredentialNameEvaluator

Description

Add support for these 2 types to be injected into the factory bean and then do the right thing on trust engine creation.

Environment

None

Activity

Brent Putman 
March 11, 2021 at 10:45 PM

Unit tests added in 9dca1611478516823d38f052c5ef292a07807c54.

Philip Smart 
November 13, 2020 at 9:23 AM

Agreed, thanks. 

Brent Putman 
November 12, 2020 at 10:18 PM

Good catch, I missed that before.  I think it makes more sense for those getters to just consistently implement @Nonnull and return empty lists if necessary. Just checked that in.

Philip Smart 
November 11, 2020 at 3:14 PM

 the getCRLs method says it returns nonnull but it actually can return nulls. Hence the getCRLs().isEmpty() conditional gives an NPE. I can change the method to declare a nullable return and add a null check if you wanted?

Philip Smart 
November 6, 2020 at 7:10 PM

This looks exactly like what I was thinking (much neater in fact). Many thanks for doing that.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Created October 31, 2020 at 12:44 AM
Updated March 11, 2021 at 10:46 PM
Resolved March 3, 2021 at 2:07 AM