...
- I think that now that 4.1 of the IdP is out the versions of the upstream projects should be pinned to 4.1.0 (OpenSAML and IdP) and parent project
- PS - pinned.
- It may also be worth aligning the version of the archetype to the IdP e.g. v 4.1.0 of the archetype is pinning to v 4.1.0 of the IdP etc.
- PS - pinned.
- The documentation probably needs to warn about using the java-parent project if you are not us
- PS - agreed, I just need to think through what happens if you don't so I can advise.
- I got confused between
-DarchetypeArtifactId=plugin-archetypeand-DgroupId=org.example.combut that was my fault and easily fixed- PS - so did I went I went back to it!
- I was going to suggest moving the Version stuff into impl, but my memory is that the tests fail and need care (because they don't run from the jar). So lets leave it there
- A
.gitignorewould be nice- Added
- The
<automatic.module.name>looked weird:net.shibboleth.idp.plugin.metadatagen.metadatagen.api- PS - the format here is `${groupId}.${pluginBase}.api` do you remember what $pluginBase was when you created the project?
- As did the
<Implementation-Vendor>FINISH</Implementation-Vendor>- PS - Added a
vendorparameter that defaults toFIXME-VENDORif not supplied.
- PS - Added a
- It would be nice if there was more templating in the
assembly.xmlfile