Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • SP patch getting closer to ready, Xerces 3.3.0 should be voted out next week or the week after.

    • Planning to move the build for Windows up to the latest everything, OpenSSL 3.3.2, etc., so needs more testing than usual.

    • OpenSSL 3.3 Windows debug build emits a ton of warnings about corrupt debugging info, not sure what it means.

  • Unit testing of the new SP’s SAML ACS flow ongoing

    • Most of the servlet request access challenges there seem to be solved, required some changes to OpenSAML to bypass some checks and assumptions

    • The SP Servlet object injection model is basically a try/finally around a call to set and clear the SP’s thread local servlet objects, so usually the model is to subclass an OpenSAML class, and call doExecute, doDecode, etc. in the try clause.

    • Not sure how much I can unit test the artifact binding, maybe something like what CAS tests do with Jetty, not sure.

Tom

  • Jira Legacy
    serverSystem Jira
    serverIdf52c7d31-6eab-3f0e-93c3-231b5754d506
    keyIDP-2323

    • wrote a test for this with Postgres + HikariCP

    • current behavior is to throw an uncaught runtime exception and present error page to user if the index storage record has an invalid value

    • method throwing exception is : AbstractConsentIndexedStorageAction#getStorageKeysFromIndex(), this is the index record whose value are all of the storage record keys

    • three use cases

      • addKeyToStorageIndex

      • removeKeyFromStorageIndex

      • pruneStorageRecords

    • probably should not throw the runtime exception but instead overwrite the index record with whatever data is current

      • may lead to orphaned records, so log to error for admin to do cleanup ?

Other