Page Comparison

...

• Mostly exbedding fields into locals

• Some changing of annotations

• A few bugs

• Use of better methods (BaseContext#getOrCreateSubContext(claz) rather that BaseContext#getSubContext(claz, true)

  • Deprecate the latter in V5?

• assert where we

  • are replacing an NPE or

  • previously checked or

  • From package we don’t own but is known to return non-null (Instant)

• Constraints the module itself cannot determine null-ness

• Currently “just” getting rid of red (errors). A second pass to get rid of (much. but not all) yellow (warnings)

• TBD:

  • idp-saml-impl (tests)

  • idp-conf (alltests)

• I’ll send out mail when the IdP is “done” (at which stage we should all use the recommended org.eclipse.jdt.core.prefs

• OpenSAML TBD (but may require structural changes - like stopping the “null in → null out” paradigm.

...