Page Comparison

...

mvn archetype:generate -DarchetypeGroupId=net.shibboleth.idp.plugin -DarchetypeArtifactId=plugin-archetype -DarchetypeVersion=0.0.1-SNAPSHOT -DgroupId=org.example.com -DartifactId=idp-plugin-test -Dversion=0.0.1-SNAPSHOT -DpluginBase=myplugin -Dvendor=vendor

Make sure you change the groupId, artifactId and pluginBase to , pluginBase and vendor to appropriate values. Or omit them and you will be prompted to add them - or leave them as they are for testing

...

• I think that now that 4.1 of the IdP is out the versions of the upstream projects should be pinned to 4.1.0 (OpenSAML and IdP) and parent project
  • PS - pinned.
• The documentation probably needs to warn about using the java-parent project if you are not us
• I got confused between -DarchetypeArtifactId=plugin-archetype and -DgroupId=org.example.com  but that was my fault and easily fixed 
  • PS - so did I went I went back to it!
• I was going to suggest moving the Version stuff into impl, but my  memory is that the tests fail and need care (because they don't run from the jar).  So lets leave it there
• A .gitignore  would be nice
  • Added
• The <automatic.module.name>  looked weird: net.shibboleth.idp.plugin.metadatagen.metadatagen.api 
  • PS - the format here is `${groupId}.${pluginBase}.api` do you remember what $pluginBase was when you created the project?
• As did the <Implementation-Vendor>FINISH</Implementation-Vendor> 
  • PS - Added a vendor parameter that defaults to FIXME-VENDOR if not supplied.
• It would be nice if there was more templating in the assembly.xml  file