All work

 
22 of 22

Don't render Help link if helpURL=null

Description

Setting

this.helpURL = null;

should stop the EDS from rendering the 'Help' link, e.g. by dynamically setting the CSS property display: none on a.IdPSelectHelpButton or removing the element or whatever.
That would spare deployers having to edit the CSS only for this, in case there's no good content to make available from the Help link.

(And while we're at it: The default value for helpURL of https://wiki.shibboleth.net/confluence/display/SHIB2/DSRoadmap should also be reconsidered and doesn't resolve anymore, so maybe even defaulting to null would be preferrable going forward, with only a comment suggesting to set this to a URL explaining the UI / login process.)

Environment

None

Details

Assignee

Reporter

Created March 23, 2020 at 8:16 PM
Updated February 27, 2024 at 3:53 PM

Activity