Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SAMLMetadataSupport.getDescriptorExtensions should be ...Extension

Description

The method SAMLMetadataSupport.getDescriptorExtensions is misnamed, as it returns a single object, not all appropriate objects. We should rename it appropriately. This is an API change, so can't appear in 0.9.x.

Meanwhile, we actually want to have a method on the 0.9.x branch which returns all of the appropriate objects. That will have to be called getDescriptorExtensionsAll for now, and be renamed to getDescriptorExtensions for 0.10.0.

Environment

None

Activity

Show:

Ian Young October 5, 2016 at 8:21 AM

I have gone with getDescriptorExtensionList for the new method on the 0.9.x branch. It might be OK to keep that for 0.10.x.

There are only a couple of callers for getDescriptorExtensions in the existing code, as it turns out, both mdrpi-related. There might be a refactoring opportunity there.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Created September 15, 2016 at 10:40 AM
Updated May 16, 2024 at 12:25 PM
Resolved April 26, 2017 at 3:58 PM